help descriptions for better clarity #635
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
noborus
commented
Oct 9, 2024
noborus
commented
- Improved command-line help and help descriptions for better clarity.
- Fixed typos in various files.
- Improved command-line help and help descriptions for better clarity. - Fixed typos in various files.
ccoVeille
reviewed
Oct 9, 2024
oviewer/input_search_test.go
Outdated
| @@ -278,14 +278,14 @@ func Test_stripBackSlash(t *testing.T) { | |||
| want string | |||
| }{ | |||
| { | |||
| name: "nonEsacpe", | |||
| name: "nonEsacape", | |||
There was a problem hiding this comment.
This no?
Suggested change
| name: "nonEsacape", | |
| name: "nonEscape", |
Or is it intentional?
oviewer/input_search_test.go
Outdated
| args: args{ | ||
| str: "\test", | ||
| }, | ||
| want: "\test", | ||
| }, | ||
| { | ||
| name: "nonEsacpe2", | ||
| name: "nonEsacape2", |
oviewer/keybind.go
Outdated
| @@ -365,7 +365,7 @@ func (k KeyBind) String() string { | |||
| k.writeKeyBind(&b, actionLastSection, "last section") | |||
| k.writeKeyBind(&b, actionFollowSection, "follow section mode toggle") | |||
| k.writeKeyBind(&b, actionSectionNum, "number of section header lines") | |||
| k.writeKeyBind(&b, actionHideOther, "toggle hide other section") | |||
| k.writeKeyBind(&b, actionHideOther, "hide other section toggle") | |||
There was a problem hiding this comment.
It's unclear if you hide other section,or iftou hide a section named "other"
So maybe this
Suggested change
| k.writeKeyBind(&b, actionHideOther, "hide other section toggle") | |
| k.writeKeyBind(&b, actionHideOther,`"hide "other" section toggle`) |
ccoVeille
reviewed
Oct 9, 2024
oviewer/input_search_test.go
Outdated
| @@ -278,14 +278,14 @@ func Test_stripBackSlash(t *testing.T) { | |||
| want string | |||
| }{ | |||
| { | |||
| name: "nonEsacpe", | |||
| name: "nonEscaape", | |||
There was a problem hiding this comment.
I cannot stop laughing, thanks @noborus
Try this
Suggested change
| name: "nonEscaape", | |
| name: "nonEscape", |
ccoVeille
approved these changes
Oct 9, 2024
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.